microsoft / microsoft/TypeScript
Predicates break arbitrarily when intersected with some types. (Probably when the predicate is generic).
Open
Nobody has claimed this yet.
Bug
Domain: Intersection
Help Wanted
- Dominant language
- Go
- Stars
- 111k
- Forks
- 14.3k
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 132
Description
🔎 Search Terms
predicate intersection
🕗 Version & Regression Information
latest version v5.6.2
⏯ Playground Link
💻 Code
interface TruthyPredicate {
<T>(o: T): o is T & {};
}
interface EmptyInterface {
}
type ConstructorSignagure = {
new (...args: any[]): any;
};
declare const arr: (string | undefined)[];
declare const predicate1: TruthyPredicate;
const filtered1 = arr.filter(predicate1); // works string[]
declare const predicate2: TruthyPredicate & EmptyInterface;
const filtered2 = arr.filter(predicate2); // doesn't work
declare const predicate3: TruthyPredicate & {} /* Empty object type instead of interface */;
const filtered3 = arr.filter(predicate3); // works string[]
declare const predicate4: TruthyPredicate & ConstructorSignagure;
const filtered4 = arr.filter(predicate4); // doesn't work
🙁 Actual behavior
Predicate stops working
🙂 Expected behavior
Predicate works
Additional information about the issue
I tried other scenarios
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the TypeScript Playground repro and the Array.filter calls in the Code section, comparing predicate1 through predicate4. Investigate why intersecting the generic TruthyPredicate with EmptyInterface or ConstructorSignagure loses narrowing; done when the affected intersections narrow the filtered array as expected without breaking the additional generic cases described.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100