microsoft / microsoft/TypeScript

Inlay parameter hints don't account for trailing required parameters

Open
#59,979 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

7.0 LS Migration Bug Domain: LS: Inlay Hints Help Wanted
Dominant language
Go
Stars
111k
Forks
14.3k
Avg merge
2d 4h
Merged PRs (30d)
132

Description

🔎 Search Terms

inlay hints parameters rest spread argument

🕗 Version & Regression Information
  • This is the behavior in every version I tried
⏯ Playground Link

N/A

💻 Code
/// <reference path="fourslash.ts" />

//// function test(...rest: [first: number, ...middle: string[], last: string]) {}
//// test(10, 'a', 'b', 'c')

verify.baselineInlayHints(undefined, {
  includeInlayParameterNameHints: "all",
  includeInlayFunctionParameterTypeHints: true,
});
🙁 Actual behavior
function test(...rest: [first: number, ...middle: string[], last: string]) {}
test(/* first: */10, /* ...middle: */'a', /* last: */'b', 'c')
🙂 Expected behavior
function test(...rest: [first: number, ...middle: string[], last: string]) {}
test(/* first: */10, /* ...middle: */'a', 'b', /* last: */'c')
Additional information about the issue

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the supplied fourslash test and the verify.baselineInlayHints call, then trace the TypeScript inlay-hints handling for tuple rest parameters with trailing required elements. Update the regression coverage so the expected baseline matches the shown output, and run the relevant fourslash or inlay-hints tests to confirm the trailing argument is labeled correctly.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.