microsoft / microsoft/TypeScript

Inferred project that currently use "current directory of tsserver host" needs some special handling

Open
#59,870 0 comments 0 reactions 1 assignee View on GitHub

@sheetalkamat is already working on this.

Since Sep 6, 2024.

Needs Investigation
Dominant language
Go
Stars
111k
Forks
14.4k
Avg merge
1d 19h
Merged PRs (30d)
117

Description

🔍 Search Terms

Inferred project, tsserver current directory

✅ Viability Checklist
⭐ Suggestion

Inferred projects that use tsserver's current directory (eg project root was not specified and is dynamic file or is single inferred project for all loose files). Esp for all the dynamic files (untitled files etc) this means we lookup package.json and files in tsserver current directory (which in most cases is vscode installation location) that seems undesirable but it also involves how to reference these dynamic files and needs some rethinking. it also ends up looking for node_modules/@types for auto type directives as well.

More prominent with #59844 and some of the tests added at https://github.com/microsoft/TypeScript/pull/59869/files#diff-d3671512f8dff77d5eabeb5694d7eae5e9b94e4d50a066c3e0205981fc102e22R59 show this as well.

📃 Motivating Example

Incorrect and unnecessary disk references to non existent files and watching those locations

💻 Use Cases
  1. What do you want to use this for?
  2. What shortcomings exist with current approaches?
  3. What workarounds are you using in the meantime?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.