microsoft / microsoft/TypeScript

Add `--strictObjectIterables` (bikeshed): exclude primitive (`string`) from `Iterable` types

Open
#59,676 4 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Needs Proposal Suggestion
Dominant language
Go
Stars
111k
Forks
14.4k
Avg merge
1d 19h
Merged PRs (30d)
117

Description

🔍 Search Terms

"iterable object", "string"

✅ Viability Checklist
⭐ Suggestion

At the TC39 meeting in 2024-07, it was decided that Iterable expects objects.

Reject primitives in iterable-taking positions

Any time an iterable or async-iterable value (a value that has a Symbol.iterator or Symbol.asyncIterator method) is expected, primitives should be treated as if they were not iterable. Usually, this will mean throwing a TypeError. If the user provides a primitive wrapper Object such as a String Object, however, it should be treated like any other Object.

Although primitive Strings are default iterable (String.prototype has a Symbol.iterator method which enumerates code points), it is now considered a mistake to iterate a String without specifying whether the String is providing an abstraction over code units, code points, grapheme clusters, or something else.

NB: This convention is new as of 2024, and most earlier parts of the language do not follow it. In particular, positional destructuring (both binding and assignment), array spread, argument spread, for-of loops, yield *, the Set and AggregateError constructors, Object.groupBy, Map.groupBy, Promise.all, Promise.allSettled, Promise.any, Promise.race, Array.from, the static from methods on typed array constructors, and Iterator.from (Stage 3 at time of writing) all accept primitives where iterables are expected.

https://github.com/tc39/how-we-work/blob/main/normative-conventions.md#reject-primitives-in-iterable-taking-positions

To follow this decision, the Iterable and string types should be separated, and APIs that accept both types should be required to explicitly specify Iterable<any> | string. Since this would be a breaking change, how about adding a new --strictObjectIterables (bikeshed) option?

In practice, the upcoming ReadableStream.from will accept Iterable<any> and AsyncIterable<any>, but will be restricted to objects. https://github.com/whatwg/streams/pull/1310

📃 Motivating Example

Enabling the --strictObjectIterables option raises a type error in the following example:

const iterable: Iterable<any> = "string";
💻 Use Cases
  1. What do you want to use this for?

    Used for ReadableStream.from and other APIs to be added in the future.

  2. What shortcomings exist with current approaches?

    Iterable object and string are not distinguished by default.

  3. What workarounds are you using in the meantime?

    Maybe Iterable<any> & object can reject string.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the proposed --strictObjectIterables behavior and the linked TC39 convention, then trace how Iterable and string are represented and checked in TypeScript. Use the motivating assignment as a type-checking case and determine the affected APIs. Done means the option rejects primitive strings as Iterable while allowing explicit Iterable | string usage.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, typescript
Domain
compilers
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.