microsoft / microsoft/TypeScript

Inconsistency between element access and object destruction

Open
#59,571 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Domain: check: Type Inference Help Wanted Possible Improvement
Dominant language
Go
Stars
111k
Forks
14.4k
Avg merge
1d 19h
Merged PRs (30d)
117

Description

🔎 Search Terms

destruct object

🕗 Version & Regression Information

Before v4.4.4, index expression in element access was also not inferred as const. So this issue starts from v4.4.4. Reproducible in Nightly build.

⏯ Playground Link

https://www.typescriptlang.org/play/#code/DYUwLgBAdhC8EEYIEMDOEDGB7KqwChtdIs4IBvFBALggCIE6V0i8IBffQnNgDzKwBtAAbIAJOSjthAXXwB6eRGUQAegH5uxChBHjJ0mbQCeHAfiA

💻 Code
let n = 1 as const
const o = { a1: "abcd" }

const x = o[`a${n}`]
//    ^? : string
const { [`a${n}`]: y } = o
//           ^? Errors: Type '{ a1: string; }' has no matching index signature for type 'string'.(2537)
🙁 Actual behavior

`a${n}` in object destruction not inferred as const ("a1")

🙂 Expected behavior

`a${n}` in object destruction should be inferred as "a1", just like the one in element access.

Additional information about the issue

A possible workaround is to add as const after `a${n}`. I think the main problem is the inconsistency between element access and object destruction, which is confusing.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked TypeScript Playground reproduction and compare the inferred type for the computed element access with the computed object-destructuring key. Trace the type-checking path for these two forms and make destructuring infer "a1" consistently; done when the example accepts the destructuring and reports the expected key type without the workaround.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.