microsoft / microsoft/TypeScript

Add `(` as a commit character to TSServer

Open
#59,525 0 comments 0 reactions 1 assignee View on GitHub

@gabritto is already working on this.

Since Aug 3, 2024.

Domain: LS: Completion Lists Suggestion
Dominant language
Go
Stars
111k
Forks
14.4k
Avg merge
1d 19h
Merged PRs (30d)
117

Description

Acknowledgement
  • I acknowledge that issues using this template may be closed without further explanation at the maintainer's discretion.
Comment

VSCode has a setting for enabling ( as a commit character ("Complete function calls"). In #59339, we started sending commit characters in TSServer, however that doesn't yet include (. We should add ( to the commit characters TSServer sends.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.