microsoft / microsoft/TypeScript
`organizeImports` does not merge value and type imports
Open
Nobody has claimed this yet.
Awaiting More Feedback
Domain: LS: Organize Imports
Suggestion
- Dominant language
- Go
- Stars
- 111k
- Forks
- 14.4k
- Avg merge
- 1d 19h
- Merged PRs (30d)
- 117
Description
🔍 Search Terms
organizeImports type
✅ Viability Checklist
- This wouldn't be a breaking change in existing TypeScript/JavaScript code
- This wouldn't change the runtime behavior of existing JavaScript code
- This could be implemented without emitting different JS based on the types of the expressions
- This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
- This isn't a request to add a new utility type: https://github.com/microsoft/TypeScript/wiki/No-New-Utility-Types
- This feature would agree with the rest of our Design Goals: https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals
⭐ Suggestion
Merge value and type imports into one import.
📃 Motivating Example
If I have the following code
import { CascadeFunction } from "@rcompat/async/cascade";
import cascade from "@rcompat/async/cascade";
And I run organizeImports, then it will be merged into
import cascade, { CascadeFunction } from "@rcompat/async/cascade";
However, if I have
import type { CascadeFunction } from "@rcompat/async/cascade";
import cascade from "@rcompat/async/cascade";
Running organizeImports will do nothing, although I would expect it to merge the imports into
import cascade, { type CascadeFunction } from "@rcompat/async/cascade";
💻 Use Cases
- What do you want to use this for?
Keeping imports clean. - What shortcomings exist with current approaches?
Imports may be doubled, and I might not notice it despite runningorganizeImports. - What workarounds are you using in the meantime?
Merge manually if I notice it.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the organizeImports entry point and trace how value and type-only imports from the same module are handled. Reproduce both examples, then verify that the type-only and value imports become one import with an inline type specifier, while existing import behavior remains unchanged.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100