microsoft / microsoft/TypeScript

Type printing does not detect that a name is shadowed in the current scope

Open
#58,456 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Bug Domain: Declaration Emit Help Wanted
Dominant language
Go
Stars
111k
Forks
14.3k
Avg merge
1d 19h
Merged PRs (30d)
117

Description

🔎 Search Terms

global shadowed declarations

🕗 Version & Regression Information
  • This is the behavior in every version I tried, and I reviewed
⏯ Playground Link

Playground Link

💻 Code
// @strict: true
// @declaration: true
// @target: es2020

// @filename: a.ts
export const o = {[Symbol.iterator]: 1}

// @filename: b.ts

import { o } from "./a";
export class Symbol { }
export const g = o;
🙁 Actual behavior

The typeof of g is { [Symbol.iterator]: number; }. This leads to an incorrect declaration since Symbol is shadowed in the current scope

🙂 Expected behavior

The typeof of g is { [globalThis.Symbol.iterator]: number; }.

Additional information about the issue

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the declaration-generation case from the Playground Link using a.ts and b.ts, with the exported Symbol shadowing the global name. Start by tracing the type printing that produces the declaration for g. Done means the generated type uses globalThis.Symbol.iterator rather than the shadowed Symbol.iterator.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.