Update import/export specifier sort on rename

🔍 Search Terms

organizeImports import sort rename

✅ Viability Checklist

• This wouldn't be a breaking change in existing TypeScript/JavaScript code
• This wouldn't change the runtime behavior of existing JavaScript code
• This could be implemented without emitting different JS based on the types of the expressions
• This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
• This isn't a request to add a new utility type: https://github.com/microsoft/TypeScript/wiki/No-New-Utility-Types
• This feature would agree with the rest of our Design Goals: https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals

⭐ Suggestion

Renaming an exported function that is imported as one of many named imports can make that list of import specifiers become unsorted. When we execute auto-imports, we try to detect how/whether an existing list of named imports is currently sorted and insert the new specifier in the correct spot. We could do something similar when updating an import or export specifier during a Rename command.

📃 Motivating Example

We have an eslint rule that enforces import sort order. I just renamed a function impliedNodeFormatForEmit to getImpliedNodeFormatForEmit, and afterwards I had to go fix the eslint rule failure in 6 different files. It would be nice not to have to do that.

💻 Use Cases

1. What do you want to use this for? Easier refactoring that doesn't make linters mad
2. What shortcomings exist with current approaches? They require me to do a lot of tedious clicking around
3. What workarounds are you using in the meantime? A lot of tedious clicking around

Start by tracing the Rename command's import/export specifier updates and comparing them with the existing auto-import sorting logic. Reproduce the motivating rename across named imports, then add coverage for preserving the established sort order and run the relevant language-service tests.