microsoft / microsoft/TypeScript
regression in "key remapping breaks definition navigation"
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 111k
- Forks
- 14.3k
- Avg merge
- 1d 19h
- Merged PRs (30d)
- 117
Description
🔎 Search Terms
key remapping breaks goto definition navigation mapped type
key remap goto def
breaks definition navigation
🕗 Version & Regression Information
- This changed between versions 4.3.5 and 4.4.4
This looks like a regression of the resolution from #47813.
⏯ Playground Link
💻 Code
interface Foo {
property: string
}
type MapItWithRemap<T> = {[P in keyof T as P extends string ? `mapped_${P}` : never]: 0}
{
let gotoDef!: MapItWithRemap<Foo>
// 0 - 4.0.5 not supported
// 4.1.5 - 4.3.5 ok
// 4.4.4+ "no definition found for 'mapped_property'"
gotoDef.mapped_property
}
🙁 Actual behavior
goto definition cannot find originating property declaration
🙂 Expected behavior
goto definition can find originating property declaration
Additional information about the issue
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the mapped-type example in the linked TypeScript Playground and compare behavior across versions 4.3.5 and 4.4.4. Trace the definition-navigation path for gotoDef.mapped_property, using the reported #47813 resolution as context; done means navigation reaches Foo.property again.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- compilers, devtools
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100