microsoft / microsoft/TypeScript
Update lib.dom.d.ts: `MutationObserverInit.attributeFilter` can accept an iterator
Open
Bug
Domain: lib.d.ts
Help Wanted
Needs Human Review
- Dominant language
- Go
- Stars
- 111k
- Forks
- 14.3k
- Avg merge
- 1d 19h
- Merged PRs (30d)
- 117
Description
⚙ Compilation target
n/a
⚙ Library
lib.dom
Missing / Incorrect Definition
MutationObserverInit
Sample Code
The following code works in Chredge, Firefox, and Safari:
const obs = new MutationObserver((records) => {
console.log(...records)
})
const s = new Set(['foo', 'bar'])
obs.observe(document.body, {
attributeFilter: s.keys() // <--------- HERE
})
document.body.setAttribute('foo', 'foo')
document.body.removeAttribute('foo')
document.body.setAttribute('bar', 'bar')
document.body.removeAttribute('bar')
Edge screenshot:
Documentation Link
https://developer.mozilla.org/en-US/docs/Web/API/MutationObserver/observe#parameters
WIP Pull Request
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.