microsoft / microsoft/TypeScript
Indexing/element access on `super` avoids instance property checks
Open
@sandersn is already working on this.
Since Sep 28, 2023.
Bug
Domain: classes
Effort: Casual
Help Wanted
Rescheduled
- Dominant language
- Go
- Stars
- 111k
- Forks
- 14.4k
- Avg merge
- 1d 19h
- Merged PRs (30d)
- 117
Description
Discovered in conversation at https://github.com/microsoft/TypeScript/pull/55892#discussion_r1339658106
class C {
yadda = () => {};
}
class D extends C {
badda() {
super["yadda"]();
}
}
new D().badda()
Currently there is no error for this code; however, if you switched it to a property access, you'd get the error introduced at https://github.com/microsoft/TypeScript/pull/54056.
class C {
yadda = () => {};
}
class D extends C {
badda() {
super.yadda(); // ❌ errors, as expected
}
}
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.