microsoft / microsoft/TypeScript

Add a recursion limit to improve stack overflow errors

Open
#55,687 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Awaiting More Feedback Suggestion
Dominant language
Go
Stars
111k
Forks
14.3k
Avg merge
1d 19h
Merged PRs (30d)
117

Description

🔍 Search Terms

"recursion", "recursion limit", "stack overflow"

✅ Viability Checklist
  • This wouldn't be a breaking change in existing TypeScript/JavaScript code
  • This wouldn't change the runtime behavior of existing JavaScript code
  • This could be implemented without emitting different JS based on the types of the expressions
  • This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
  • This feature would agree with the rest of our Design Goals: https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals
⭐ Suggestion

It would be nice to have a recursion limit that allows a better error message in stack overflow errors like these, and that could potentially include more context about the recursive function.

📃 Motivating Example

This VS feedback item that shows how the error surfaced to the user is quite overwhelming.

💻 Use Cases
  1. What do you want to use this for? Debugging/fixing stack overflow errors.
  2. What shortcomings exist with current approaches? The error lists/output panes in editors aren't great at displaying huge stacks like these.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No implementation files, tests, or entry points are named. Start by reviewing the linked Visual Studio feedback and the TypeScript compiler's current stack-overflow handling, then determine the scope and design of a recursion limit. Done should include a better diagnostic with useful recursive context without changing existing JavaScript behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, typescript
Domain
compilers
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.