microsoft / microsoft/TypeScript
discriminated union type narrow when destructuring object within desturct array
Open
Nobody has claimed this yet.
Experimentation Needed
Suggestion
- Dominant language
- Go
- Stars
- 111k
- Forks
- 14.4k
- Avg merge
- 1d 19h
- Merged PRs (30d)
- 117
Description
🔎 Search Terms
destructuring object within destructured array, discriminated union
🕗 Version & Regression Information
the error part appeared in every version I tried
⏯ Playground Link
💻 Code
type FirstItem = {
type: 'first'
value: string
}
type SecondItem = {
type: 'second'
value: number
}
type ThirdItem = {
type: 'third'
value: boolean
}
const a: (FirstItem | SecondItem | ThirdItem)[] = []
// test 1
a.forEach(({ type, value }) => {
if (type === 'first') {
// ok: string
console.log(value)
}
})
// test 2
for (const { type, value } of a) {
if (type === 'first') {
// ok: string
console.log(value)
}
}
const b: [ FirstItem | SecondItem | ThirdItem ][] = []
// test 3
for (const [ v ] of b) {
if (v.type === 'first') {
// ok
console.log(v.value)
}
}
// test 4
b.forEach(([{ type, value }]) => {
if (type === 'first') {
// not ok: string | number | boolean
console.log(value)
}
})
// test 5
for (const [ { type, value } ] of b) {
if (type === 'first') {
// not ok: string | number | boolean
console.log(value)
}
}
🙁 Actual behavior
the code above, test4 and test5 can not narrow to the string type like test1, test2 or test3
🙂 Expected behavior
I expected the value in the loop to infer successfully
Additional information about the issue
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the Playground Link and reproduce tests 4 and 5 from the issue, comparing them with tests 1–3. Trace the type-checking behavior for destructured objects inside destructured arrays; done means the value variable narrows to string when type is 'first'.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100