microsoft / microsoft/TypeScript

Resolve documentation for type aliases

Open
#55,572 0 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Awaiting More Feedback Suggestion
Dominant language
Go
Stars
111k
Forks
14.3k
Avg merge
1d 19h
Merged PRs (30d)
117

Description

🔍 Search Terms

type alias hover documentation

✅ Viability Checklist
  • This wouldn't be a breaking change in existing TypeScript/JavaScript code
  • This wouldn't change the runtime behavior of existing JavaScript code
  • This could be implemented without emitting different JS based on the types of the expressions
  • This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
  • This feature would agree with the rest of our Design Goals: https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals
⭐ Suggestion

When a type is a literal type alias of another type without any generics, it should take over the documentation of the aliased type.

I originally proposed this in https://github.com/microsoft/TypeScript/issues/49798#issuecomment-1228787745, but I think this deserves its own issue.

📃 Motivating Example

Type aliases should resolve the documentation of the type they alias.

/**
 * A boolean, number, or string literal
 */
type PrimitiveLiteral = boolean | number | string

type Primitive = PrimitiveLiteral

// hovering on 'Primitive' should show "A boolean, number, or string literal"
let value: Primitive
💻 Use Cases
  1. What do you want to use this for?

Type aliases are a common way to import types when using types in JSDoc. For example:

/**
 * @typedef {import('unist').Point}  Point
 */

/**
 * @param {Point} point
 */
function stringifyPoint(point) {}
  1. What shortcomings exist with current approaches?

Hovering Point in the example, provides no documentation. When type definitions are generated, they create a type alias which has the same problem.

  1. What workarounds are you using in the meantime?

Navigate to the original type to read its documentation, or look it up online.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Begin by tracing hover documentation for the Primitive alias and the JSDoc/import typedef example in the TypeScript language service. Compare current behavior with the requested inherited documentation for non-generic literal aliases, then add focused coverage and verify the hover output; the issue names no files or tests, so locating the relevant paths is part of the work.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
compilers, tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.