microsoft / microsoft/TypeScript

Cannot await Thenable

Open
#55,408 9 comments 3 reactions 1 assignee View on GitHub

@rbuckton is already working on this.

Since Aug 17, 2023.

Needs Investigation
Dominant language
Go
Stars
111k
Forks
14.3k
Avg merge
1d 19h
Merged PRs (30d)
117

Description

🔎 Search Terms

"Type of 'await' operand must either be a valid promise or must not contain a callable 'then' member.", "TS1320"

🕗 Version & Regression Information
  • This is the behavior in every version I tried, and I reviewed the FAQ for entries about async
⏯ Playground Link

https://www.typescriptlang.org/play?target=9#code/PTAEAEBcEMCcHMCmkBcoCiBlATABm9gFCEDGA9gHYDOkoAtgJ4AqAFohdAEYA2ioAvKADehUKEhsKACkoAxAK7cAZgEtuvACYAaUJQBKiAFaISkRBoCUQ0LGTzYFXRQXK1mgPwA6KQEYLoAF9CIMJoKgYKElAleUjIFUpQaDpoFWl-ETFQcmpaWAEkgHdU2kZWdi5eAG5RMRyqMl5PbjJ4KQByADdobnlEdp1YHXaUAfEGAAdEMiUbCxqs20h7R1gakLLJSr4qaHiqVUQqUAAFWDI6FSpEABkVAGtEAB4KeTpORFgAPmJryCYVHRpvJIFJkqkKDpcBYgA

💻 Code
// @target: ES2022

const myThenable = {
  then(onFulfilled, onRejected){ return onFulfilled?.(1) }
}

async function amain() {
   const r = await myThenable;
   console.log('value', r, ':', typeof r);
   return r;
}

myThenable satisfies PromiseLike<number>

setTimeout(amain, 0)

Workbench Repro

🙁 Actual behavior

An error is shown:

Type of 'await' operand must either be a valid promise or must not contain a callable 'then' member.

🙂 Expected behavior

I expect no error or a suppressible warning. I also expect some explanation of "why" or a suggestion like "wrap the thenable in a Promise.resolve()"

Additional information about the issue

This is valid JavaScript, and executes in Deno, Node, Chrome, and Firefox.

Note that await doesn't even require its argument to be a PromiseLike - then may have return type void or even never!

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.