microsoft / microsoft/TypeScript
Provide support for comma insertion with snippet completion
Open
@navya9singh is already working on this.
Since Jun 21, 2023.
Domain: LS: Completion Lists
Rescheduled
Suggestion
- Dominant language
- Go
- Stars
- 111k
- Forks
- 14.3k
- Avg merge
- 1d 19h
- Merged PRs (30d)
- 117
Description
Bug Report
Support comma insertion with snippet completion
🔎 Search Terms
object literal method snippet
💻 Code
interface T {
aaa: string;
foo(): void;
}
const obj: T = {
aaa: ""
/**/
}
🙁 Actual behavior
const obj: T = {
aaa: ""
foo() {
},
}
On selecting the completion that inserts just foo, the comma gets inserted, but on selecting the snippet completion foo(), the comma is not inserted. This happens because both the comma insertion and snippet completion have their own CompletionSource.
🙂 Expected behavior
const obj: T = {
aaa: "",
foo() {
},
}
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.