microsoft / microsoft/TypeScript
Generics are lost during `Function.prototype.bind()` and `Function.prototype.call()`
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 111k
- Forks
- 14.3k
- Avg merge
- 1d 19h
- Merged PRs (30d)
- 117
Description
Suggestion
🔍 Search Terms
generic, bind, call
✅ Viability Checklist
My suggestion meets these guidelines:
- This wouldn't be a breaking change in existing TypeScript/JavaScript code
- This wouldn't change the runtime behavior of existing JavaScript code
- This could be implemented without emitting different JS based on the types of the expressions
- This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
- This feature would agree with the rest of TypeScript's Design Goals.
⭐ Suggestion
Currently, binding or calling a function loses its generics. Suggestion: Don't lose the generic.
📃 Motivating Example
Let's say I have a generic function getMediaAd
export async function getMediaAd<T extends Ad>(
this: Client,
params: { locale?: string; media_id: string; format: T['format'] },
) {
const url = this.cmsUrl(`api/ads/random`, params)
if (!params.locale) url.searchParams.set('locale', this.locale)
return this.get<T>(url, this.cmsHeaders())
}
This function can obtain multiple types of ad formats, determined by T.
I want to put this function inside a Client class to access some client-specific features.
export class Client {
getMediaAd = getMediaAd.bind(this)
}
However, when I do that, this.getMediaAd loses its generic parameter.
Losing the generic parameter means I can't tell it what is T supposed to be, like this:
export async function getMediaBillboardAd(
this: Client,
params: { locale?: Intl.UnicodeBCP47LocaleIdentifier; media_id: string },
) {
return this.getMediaAd<AdBillboard>({ ...params, format: adFormat.billboard })
}
Here, T is AdBillboard. However, getMediaAd expects 0 generic parameters.
💻 Use Cases
I want to use this to create an API wrapper client, but keep the ability to declare functions in different files.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the motivating generic getMediaAd example and the Client.getMediaAd assignment using Function.prototype.bind(). Compare the stated behavior for bind() and call() with the current TypeScript type system, then define how generic parameters should be preserved without changing JavaScript runtime behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, typescript
- Domain
- compilers
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100