microsoft / microsoft/TypeScript
Incorrect class #private fields initialization order with target ES2022 and useDefineForClassFields set to false
@rbuckton is already working on this.
Since May 10, 2023.
- Dominant language
- Go
- Stars
- 111k
- Forks
- 14.3k
- Avg merge
- 1d 19h
- Merged PRs (30d)
- 117
Description
Bug Report
🔎 Search Terms
ES2022 class field initialization order
private fields order
useDefineForClassFields false
🕗 Version & Regression Information
- This changed between versions 4.9.5 and 5.0.4
⏯ Playground Link
5.0.4 with runtime error (useDefineForClassFields: false, target: ES2022)
4.9.5 without runtime error (useDefineForClassFields: false, target: ES2022)
💻 Code
class Buzz {
wow = 'one'
}
class Foo {
#bar = this.buz.wow;
constructor(private buz: Buzz) {}
}
new Foo(new Buzz())
🙁 Actual behavior
With 5.0.4 and useDefineForClassFields: false, target: ES2022 the above code fails in runtime because #bar = this.buz.wow; stays initialized before constructor, this doesn't happen if "normal private" is used (private bar = this.buz.wow;). Such construct works without issues on 4.9.5.
🙂 Expected behavior
The initialization is done in the same way as on 4.9.5.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.