microsoft / microsoft/TypeScript

【bug】ThisType is invalid when using param on generic object

Open
#52,969 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Bug Domain: This-Typing Help Wanted
Dominant language
Go
Stars
111k
Forks
14.3k
Avg merge
1d 19h
Merged PRs (30d)
117

Description

Bug Report

🔎 Search Terms

ThisType Object Generic

🕗 Version & Regression Information

I was unable to test this on prior versions because I was not using this feature previously

⏯ Playground Link

Playground link with relevant code

💻 Code
type ILifetime = {
  onShareTimeline: () => string
}

function createObject<D>(obj: D & ILifetime & ThisType<D>) {
  console.warn(obj)
}

// working
createObject({
  title: 'demo',
  onShareTimeline() {
    return ''
  }
})

// not working
createObject({
  title: 'demo',
  onShareTimeline() {
    return this.title
  }
})
🙁 Actual behavior

The generic type is broken

🙂 Expected behavior

The generic type should contain the object properties as those are finally included into the result

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked TypeScript Playground and the createObject generic example, comparing the working callback with the version that reads this.title. Investigate how ThisType is applied during generic object contextual typing; done means the inferred object type includes title and the callback can return this.title without an error.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.