microsoft / microsoft/TypeScript
Private function parameters
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 111k
- Forks
- 14.3k
- Avg merge
- 1d 19h
- Merged PRs (30d)
- 117
Description
Suggestion
🔍 Search Terms
private function parameter
✅ Viability Checklist
My suggestion meets these guidelines:
- This wouldn't be a breaking change in existing TypeScript/JavaScript code
- This wouldn't change the runtime behavior of existing JavaScript code
- This could be implemented without emitting different JS based on the types of the expressions
- This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
- This feature would agree with the rest of TypeScript's Design Goals.
⭐ Suggestion
Hi, I would like to propose adding private function parameters to TypeScript. Private function parameters can be only provided by the function itself when it calls itself recursively. Providing them when called in a different context is an error.
Private function parameters always come after public function parameters in the function signature.
📃 Motivating Example
https://twitter.com/TomasHubelbauer/status/1626321532187189248
function recursive(input: string; private state: State = { … }) {
// …
if (logic) {
return recursive(input, { ...state, extra: true });
}
// …
}
// This is okay
recursive('test');
// This is an error
recursive('test', externalState);
// We have to do this now to achieve hiding `state` from the caller
function recursivePublic(input: string) {
return recursive(input);
}
💻 Use Cases
Enables writing recursive functions which need parameters to pass state between calls without having to private the "implementation" function which has the parameter for state and export a different function that has the same signature except for the state parameter(s) and is meant for outside callers.
There are two workarounds I am aware of:
-
Write another function which is public, make the original one private and export only the public one which doesn't have the state parameter in its sigature
The shortcoming of the this workaround is that we need to introduce another function that is meant to be called by others which passes along the parameters to the implementation function which does the real processing but has the extra parameter(s) which cannot be exposed to non-self callers. -
Use function within a function, call the local function when the state parameter is uninitialized and handover to it
This is a special case of the above, we just move the implementation function into the wrapper function.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the proposed private-parameter syntax and the motivating recursive-function example. Compare the two listed workarounds and determine the type-checking rules needed for self-calls versus external calls; done means a settled design with its impact on TypeScript's type system and JavaScript emit established.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- compilers
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100