microsoft / microsoft/TypeScript

Import auto-import doesn't take into account the current import statement

Open
#52,788 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Experience Enhancement Help Wanted Suggestion
Dominant language
Go
Stars
111k
Forks
14.3k
Avg merge
1d 19h
Merged PRs (30d)
117

Description

Bug Report

🔎 Search Terms
  • import
  • auto-import
💻 Code

Use Visual Studio for the following:

  1. In file1.ts, write export zero = 0;
  2. In file2.ts, write import ze and notice the completion entry for zero.
🙁 Actual behavior

If the completion entry for zero is selected, the contents in file2.ts will be replaced by:

import { zero } from "./file1.ts";
import z

After discussing the bug with @andrewbranch, he pointed out how this is the correct behavior because the entry that VS is showing corresponds to an auto-import.

🙂 Expected behavior

The auto-import completion entry shouldn't show up if the current line corresponds to an import statement itself (in case the editor doesn't have preferences.includeCompletionsForImportStatements and preferences.includeCompletionsWithInsertText set).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the behavior in Visual Studio using file1.ts and file2.ts, with import ze in file2.ts and the stated completion preferences. Inspect the auto-import completion behavior for an import statement; done means the auto-import entry is not shown in that context.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
developer-experience
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.