microsoft / microsoft/TypeScript

Add semantic token scope for object literal shorthand properties

Open
#52,658 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Experience Enhancement Help Wanted Suggestion
Dominant language
Go
Stars
111k
Forks
14.3k
Avg merge
1d 19h
Merged PRs (30d)
117

Description

TS Template added by @mjbvz

TypeScript Version: 4.9.5

Search Terms

  • Semantic tokens
  • semantic colorization

I want a way to configure vscode to treat literal property value shorthand as parameter or variable, not just a property key.

image
Above is what happend in vscode. I configure a purple color for parameters, but vscode treat literal property value shorthand as "property" key, not "parameter" or "variable". That's bad for me to find out how parameters are processed in a function quickly.

However, webstorm is ok in this case.
image

My settings is as follows:

  "editor.tokenColorCustomizations": {
    "[Default Dark+]": {
      "keywords": "#499CD5",
      "textMateRules": [
        { 
          "scope": "variable.parameter",
          "settings": {
            "foreground": "#C288BE"
          }
        },
      ],
    }
  },

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the behavior in VS Code using the supplied TypeScript example and editor.tokenColorCustomizations settings. Start by tracing how TypeScript semantic tokens classify object-literal shorthand properties, then verify that the shorthand key remains a property while its value receives a parameter or variable scope. Done means the configured parameter or variable color applies to the value portion as requested.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript, vscode
Domain
developer-experience, tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.