microsoft / microsoft/TypeScript
narrowing doesn't work when spreading from ternary operator
Open
Nobody has claimed this yet.
Awaiting More Feedback
Suggestion
- Dominant language
- Go
- Stars
- 111k
- Forks
- 14.4k
- Avg merge
- 1d 19h
- Merged PRs (30d)
- 117
Description
Bug Report
🔎 Search Terms
narrow spread ternary
🕗 Version & Regression Information
v4.5.0-dev.20210907
⏯ Playground Link
Playground link with relevant code
💻 Code
interface Foo {
type: "foo"
foo: string
}
interface Bar {
type: "bar"
bar: number
}
declare const thing: Foo|Bar
const otherThing: Foo|Bar = { //error: Type '"foo" | "bar"' is not assignable to type '"foo"'.
type: thing.type,
...(thing.type === "foo" ? { foo: thing.foo } : { bar: thing.bar })
}
🙁 Actual behavior
error: Type '"foo" | "bar"' is not assignable to type '"foo"'.
🙂 Expected behavior
no error, since it's not possible for the object to not match either the Foo or Bar types
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the linked TypeScript Playground and the minimal Foo|Bar example. Trace how the type checker handles narrowing inside a ternary expression used in an object spread. Done means the example type-checks without error while preserving correct checking for incompatible spread branches.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100