microsoft / microsoft/TypeScript
TS2377 not reported when 'super' is called conditionally
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 111k
- Forks
- 14.4k
- Avg merge
- 1d 19h
- Merged PRs (30d)
- 117
Description
Bug Report
The TS2377 error is reported when the constructor of a derived class does not contain a call to 'super'. However, it is not reported when only some branches contain the call but not others.
🔎 Search Terms
TS2377 super class missing branch
🕗 Version & Regression Information
- This is the behavior in every version I tried, and I reviewed the FAQ for entries about Classes
⏯ Playground Link
Playground link with relevant code
💻 Code
class CustomError extends Error {
constructor(value: string | number) {
if (typeof value === 'string') {
super(value)
} else {
// oops, no super() call!
}
}
}
🙁 Actual behavior
TypeScript does not report any errors for the above code.
🙂 Expected behavior
TypeScript should report TS2377 for the above code, since 'super' isn't called in every branch.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the linked Playground example and confirm the missing TS2377 diagnostic when the conditional branches do not all call super. Trace the TypeScript compiler's handling of derived-class constructors and control-flow branches, then add coverage showing that TS2377 is reported unless every branch calls super.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 48/100