microsoft / microsoft/TypeScript

Quick fix to declare overridden method on base class

Open
#45,172 2 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Awaiting More Feedback Suggestion
Dominant language
Go
Stars
111k
Forks
14.4k
Avg merge
1d 19h
Merged PRs (30d)
117

Description

From https://github.com/microsoft/vscode/issues/129130#issuecomment-885409056

Suggestion

Add a new quick fix on a subclass that tried to override a non-existent method to add that method to the base class.

For example, starting with:

class Base {

}

class Sub extends Base {
	override foo() {}
}

The quick fix would generate:

class Base {
	foo() {
		throw new Error("Not implemented");
	}
}

class Sub extends Base {
	override foo() {}
}

🔍 Search Terms

  • Override
  • quick fix
  • code action

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the TypeScript language-service quick-fix or code-action handling for an override of a non-existent method. Trace how the diagnostic is produced, then inspect the existing quick-fix tests before adding coverage for the Base and Sub example. Done means the quick fix generates the base method with the shown not-implemented body.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
compilers
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.