microsoft / microsoft/TypeScript

Harden response delivery to ensure services is consistent with server

Open
#44,260 1 comment 0 reactions 1 assignee View on GitHub

@orta is already working on this.

Since Jun 7, 2021.

Domain: LS: TSServer Infrastructure Rescheduled
Dominant language
Go
Stars
111k
Forks
14.3k
Avg merge
2d 4h
Merged PRs (30d)
132

Description

Spoke with @andrewbranch

If you [add] a member to any protocol.*Response, there's a significant chance that your fourslash tests [will] work but it [won't] actually work over the TS Server because session.ts picked apart the response in the process of converting positions to line/character and didn't know to put it back

How could we fix it?

Destructuring with an object rest instead of requiring session.ts to name every property it wants to preserve

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.