microsoft / microsoft/TypeScript
normalizeSlashes should probably no-op on *nix
Open
@jakebailey is already working on this.
Since Feb 1, 2022.
Domain: Performance
Needs Investigation
- Dominant language
- Go
- Stars
- 111k
- Forks
- 14.3k
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 132
Description
As @dmichon-msft pointed out, Linux file names can contain backslashes, so indiscriminately converting them into forward slashes is probably a bad idea. Redefining normalizeSlashes as the identity function on non-Windows platforms would also be a perf win, since it's very hot code. The biggest concern is that someone might be depending on this (e.g. I think you can use backslashes in paths in tsconfig.json).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.