microsoft / microsoft/TypeScript
redux-orm broken by #43624
Open
@weswigham is already working on this.
Since Apr 28, 2021.
Bug
Domain: This-Typing
Rescheduled
- Dominant language
- Go
- Stars
- 111k
- Forks
- 14.3k
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 132
Description
The nightly dtslint run for 4/28 fails on redux-orm, with new errors on examples like:
export default class Model<MClass extends typeof AnyModel = typeof AnyModel, Fields extends ModelFieldMap = any> {
// ...
readonly ref: Ref<this>;
// ...
}
export class AnyModel extends Model {}
export type Ref<M extends AnyModel> = {
[K in keyof RefFields<M>]: ModelFields<M>[K] extends AnyModel ? IdType<ModelFields<M>[K]> : RefFields<M>[K];
};
ERROR: 118:23 expect TypeScript@4.3 compile error:
Type 'this' does not satisfy the constraint 'AnyModel'.
Type 'Model<MClass, Fields>' is not assignable to type 'Model<typeof AnyModel, any>'.
Type 'typeof AnyModel' is not assignable to type 'MClass'.
'typeof AnyModel' is assignable to the constraint of type 'MClass', but 'MClass' could be instantiated with a different subtype of constraint 'typeof AnyModel'.
Almost certainly a result of https://github.com/microsoft/TypeScript/pull/43624, but it could be #42449 or #43835, since they went in on the same day.
If this is an intended result of that PR, can you fix up redux-orm? A naive change to Ref<M extends Model> doesn't work.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.