microsoft / microsoft/TypeScript
`unknown` isn’t narrowed by assignment
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 111k
- Forks
- 14.3k
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 132
Description
Bug Report
🔎 Search Terms
try block
🕗 Version & Regression Information
- This is the behavior in every version I tried, and I reviewed the FAQ for entries about try-catch blocks
⏯ Playground Link
Playground link with relevant code
💻 Code
function f(request: {params: {[param: string]: unknown;}}) {
let x = request.params.x;
try {
x = validate(x);
} catch (e) {}
try {
takesString(x); // Fails to compile, x is of type unknown.
} catch (e) {}
}
function validate(x: unknown): string { return ""; }
function takesString(s: string) {}
🙁 Actual behavior
In this example, the code fails to compile because tsc has deduced x in the second block to be of type unknown
🙂 Expected behavior
Since we have successfully exited the first try-catch block, x's type should be narrowed to string in the second.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Run the linked TypeScript Playground example first to reproduce the failure around the two try-catch blocks. Then trace the compiler's control-flow narrowing for assignments across try-catch boundaries and add a regression test for the shown case; done means tsc accepts takesString(x) after the first block without weakening narrowing elsewhere.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100