microsoft / microsoft/TypeScript
Print a warning if using 'ts.factory' in a transformer
Open
Nobody has claimed this yet.
Experience Enhancement
Suggestion
- Dominant language
- Go
- Stars
- 111k
- Forks
- 14.3k
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 132
Description
Noted in https://github.com/microsoft/TypeScript/issues/43407#issuecomment-809724790, we should discourage the use of ts.factory from within a transformer, as the transformer should instead use the factory provided to its context argument.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the transformer implementation and the discussion linked from the issue, focusing on how a transformer's context and factory are handled. Done means the relevant use of ts.factory produces a warning while the context-provided factory remains the recommended path.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- compilers
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100