microsoft / microsoft/TypeScript

TS Server fatal error: Debug Failure. False expression.

Open
#43,067 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Needs Investigation
Dominant language
Go
Stars
111k
Forks
14.3k
Avg merge
2d 4h
Merged PRs (30d)
132

Description

Issue Type: Bug

❗️❗️❗️ Please fill in the sections below to help us diagnose the issue ❗️❗️❗️

TypeScript Version: 4.3.0-dev.20210302

Steps to reproduce crash

  1. Three (3) VSCode windows open, each using TypeScript
  2. Working through 100+ errors, in one window
  3. Performed npm unlink then npm install ../common just prior to this bug report showing.
  4. Opened a file just after step 3.

TS Server Log
❗️Server logging disabled. To help us fix crashes like this, please enable logging by setting:

"typescript.tsserver.log": "verbose"

After enabling this setting, future crash reports will include the server log.

TS Server Error Stack
Server: syntax

Error: Debug Failure. False expression.
    at ProjectService.applyChangesInOpenFiles (/Users/scottpage/.vscode-insiders/extensions/ms-vscode.vscode-typescript-next-4.3.20210302/node_modules/typescript/lib/tsserver.js:159733:34)
    at Session.handlers.ts.Map.ts.getEntries._a.<computed> (/Users/scottpage/.vscode-insiders/extensions/ms-vscode.vscode-typescript-next-4.3.20210302/node_modules/typescript/lib/tsserver.js:160803:46)
    at /Users/scottpage/.vscode-insiders/extensions/ms-vscode.vscode-typescript-next-4.3.20210302/node_modules/typescript/lib/tsserver.js:162687:88
    at IOSession.Session.executeWithRequestId (/Users/scottpage/.vscode-insiders/extensions/ms-vscode.vscode-typescript-next-4.3.20210302/node_modules/typescript/lib/tsserver.js:162678:28)
    at IOSession.Session.executeCommand (/Users/scottpage/.vscode-insiders/extensions/ms-vscode.vscode-typescript-next-4.3.20210302/node_modules/typescript/lib/tsserver.js:162687:33)
    at IOSession.Session.onMessage (/Users/scottpage/.vscode-insiders/extensions/ms-vscode.vscode-typescript-next-4.3.20210302/node_modules/typescript/lib/tsserver.js:162713:35)
    at Interface.<anonymous> (/Users/scottpage/.vscode-insiders/extensions/ms-vscode.vscode-typescript-next-4.3.20210302/node_modules/typescript/lib/tsserver.js:165398:31)
    at Interface.emit (events.js:315:20)
    at Interface._onLine (readline.js:329:10)
    at Interface._normalWrite (readline.js:474:12)
    at Socket.ondata (readline.js:186:10)
    at Socket.emit (events.js:315:20)
    at addChunk (_stream_readable.js:295:12)
    at readableAddChunk (_stream_readable.js:271:9)
    at Socket.Readable.push (_stream_readable.js:212:10)
    at Pipe.onStreamRead (internal/stream_base_commons.js:186:23)

VS Code version: Code - Insiders 1.54.0-insider (Universal) (42e27fe5cdc58539dad9867970326a297eb8cacf, 2021-03-02T19:09:42.206Z)
OS version: Darwin x64 20.3.0

System Info
Item Value
CPUs Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz (16 x 2400)
GPU Status 2d_canvas: enabled
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
oop_rasterization: enabled
opengl: enabled_on
protected_video_decode: unavailable_off
rasterization: enabled
skia_renderer: disabled_off_ok
video_decode: enabled
webgl: enabled
webgl2: enabled
Load (avg) 3, 3, 2
Memory (System) 32.00GB (0.47GB free)
Process Argv --crash-reporter-id a2781316-e190-41d1-8f67-f530cb44e09e
Screen Reader no
VM 0%
Extensions (28)
Extension Author (truncated) Version
vscode-toggle-quotes Bri 0.3.4
vscode-eslint dba 2.1.14
gitlens-insiders eam 2021.3.204
vscode-html-css ecm 1.10.2
EditorConfig Edi 0.16.4
auto-rename-tag for 0.1.6
todo-tree Gru 0.0.199
vue-snippets hol 1.0.4
vue jcb 0.1.5
dotenv mik 1.0.1
vscode-docker ms- 1.10.0
vscode-dotnet-runtime ms- 1.0.0
mssql ms- 1.10.1
remote-containers ms- 0.163.0
remote-ssh ms- 0.64.0
remote-ssh-edit ms- 0.64.0
remote-wsl ms- 0.54.0
vscode-remote-extensionpack ms- 0.20.0
azure-account ms- 0.9.6
vscode-typescript-next ms- 4.3.20210302
debugger-for-chrome msj 4.12.12
vetur oct 0.33.0
swdc-vscode sof 2.5.2
electron-tools tms 1.1.3795
tmswebcore tms 1.2.4095
omnipascal Wos 0.18.0
markdown-all-in-one yzh 3.4.0
html-css-class-completion Zig 1.20.0
A/B Experiments
vsliv695:30137379
vsins829:30139715
vsliv368:30146709
vsreu685:30147344
python383:30185418
pythonvspyt617cf:30253240
pythonvspyt602:30263608
vspor879:30202332
vspor708:30202333
vspor363:30204092
vstry244:30244315
pythonvsdeb440:30224570
pythonvsded773:30223139
vstes627:30244334
pythonvspyt875:30259475
pythonvsnew554:30265444
pythontb:30258533
vsget980:30265949

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The reported entry point is ProjectService.applyChangesInOpenFiles in the tsserver.js stack trace. Enable verbose TS Server logging, reproduce the three-window workflow with npm unlink and npm install ../common, and inspect the resulting log around the syntax-server request. Done means the workflow no longer produces the fatal Debug Failure.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript, vscode
Domain
devtools
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.