microsoft / microsoft/TypeScript
'Compile on save' feature for TypeScript slower than a Rebuild
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 111k
- Forks
- 14.3k
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 132
Description
This issue has been moved from a ticket on Developer Community.
[severity:It's more difficult to complete my work]
When I change a TS file and save it, most of the times will Visual Studio start "compiling" all TS files in the project directory. It starts looping through all the files, and the status bar shows the following for each file:
Generation of '..... ts' complete. Remaining files still compiling.
And it finishes with the message:
Output(s) generating successfully.
I have 493 TS files in total, in several VS projects, in the same directory, and the recompiling takes 50 seconds to complete, after each save. Yet, a complete project rebuild takes only 25 seconds. This means that the compile-on-save feature is not usable (for me), and most of the times I will have to rebuild my entire project after each change in order to save time.
The first problem that I see is that all existing TS files in the project directory are recompiled, regardless if they are part of the current project or not. It would have been better to recompile only the files included in the current project -- that would save some time.
The second problem is that most of the time there is no need to recompile all files after a small change -- only the changed file should be recompiled. Sometimes, VS detects that situation and does just that, but rarely. Most of the times it recompiles all files, completely needless. VS should analyze better if all the files need to be recompiled, or just the changed file. In my case, I would be quite satisfied if I had a setting to limit the compile-on-save feature only to the changed file. When I want all files to be compiled I can just rebuild the project myself -- an automatic feature for that is not that usefull.
Original Comments
Feedback Bot on 1/26/2021, 06:04 PM:
We have directed your feedback to the appropriate engineering team for further evaluation. The team will review the feedback and notify you about the next steps.
Benjamin Lichtman [MSFT] on 1/27/2021, 10:30 AM:
Thank you for your feedback!
Where possible, the compile-on-save feature should only recompile necessary files.
However, this is sometimes not possible - for example, when values are defined globally (as opposed to within modules), it is very difficult to track the impact of changes, and so we conservatively recompile all possibly impacted files.
In order for us to investigate this further, could you please provide us with log files so that we can conduct further research?
- Please follow the instructions below in the “Enable detailed language service logging” section to collect the log files.
- After reproducing the problem, log files should be created in the folder specified.
- Upload these files to this feedback by replying and inserting the files using the insert (attach) button.
We look forward to hearing from you!
Remus Vasii on 1/29/2021, 09:24 AM:
(private comment, text removed)
Original Solutions
(no solutions)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No repository files or tests are named. Start with the detailed language service logging instructions linked in the issue, reproduce compile-on-save in the multi-project directory, and inspect the logs to determine why unrelated files are rebuilt. Done should mean compile-on-save limits work to the current project and necessary changed files, or provides a setting for changed-file-only compilation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- build-system, developer-experience
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100