microsoft / microsoft/TypeScript

concat arrays

Open
#41,913 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

In Discussion Suggestion
Dominant language
Go
Stars
111k
Forks
14.3k
Avg merge
2d 4h
Merged PRs (30d)
132

Description

TypeScript Version: 4.1.2 & Nightly 4.2

Search Terms: concat, spread

Code

type First = [number, string];
type Second = [string, string];
type Result = [...First, ...Second];

function concat (first: First, second: Second): Result {
    return first.concat(second); // error
}

function spread (first: First, second: Second): Result {
    return [...first, ...second]; // ok
}

Expected behavior: concat function works similarly to spread function without an error.

Actual behavior: Type '(string | number)[]' is not assignable to type '[number, string, string, string]'. Target requires 4 element(s) but source may have fewer.(2322)

Playground Link:
playground

Related Issues: https://github.com/microsoft/TypeScript/issues/36554

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the tuple concat example in the linked TypeScript playground and compare it with the spread version. Trace the compiler behavior for Array.concat on tuple types; done means concat is accepted with the declared Result type without weakening the tuple-length check.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.