microsoft / microsoft/TypeScript
Cache importFixes/fixMissingImport in getCodeFixes requests
Open
@andrewbranch is already working on this.
Since Dec 10, 2020.
Needs Investigation
- Dominant language
- Go
- Stars
- 111k
- Forks
- 14.3k
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 132
Description
Search Terms
- getCodeFixes cache
Suggestion
In tsserver, the completionInfo request benefits from a cache of import suggestions.
Could the getCodeFixes request be extended to use a suggestion imports cache as well?
Both call codeFixes.forEachExternalModuleToImportFrom, which can be very slow in a large project. Thanks!
Checklist
My suggestion meets these guidelines:
- This wouldn't be a breaking change in existing TypeScript/JavaScript code
- This wouldn't change the runtime behavior of existing JavaScript code
- This could be implemented without emitting different JS based on the types of the expressions
- This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
- This feature would agree with the rest of TypeScript's Design Goals.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.