microsoft / microsoft/TypeScript

Provide a way to clone a ast tree includes it's all children

Open
#41,846 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Awaiting More Feedback Domain: API Suggestion
Dominant language
Go
Stars
111k
Forks
14.3k
Avg merge
2d 4h
Merged PRs (30d)
132

Description

Search Terms

api, plugin, transformer

Suggestion

Provide a way to clone an ast tree not only top level node but includes it's all children.

Use Cases

Currently, replace node with the original node is not work with textChanges(It will fail an assert).

So I have to do it like this: https://github.com/HearTao/ts-react-hooks-tools/blob/main/src/utils.ts#L458-L476.

I think It's not a good idea even it works.

Examples

Checklist

My suggestion meets these guidelines:

  • This wouldn't be a breaking change in existing TypeScript/JavaScript code
  • This wouldn't change the runtime behavior of existing JavaScript code
  • This could be implemented without emitting different JS based on the types of the expressions
  • This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
  • This feature would agree with the rest of TypeScript's Design Goals.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the linked service.ts usage and utils.ts workaround for replacing AST nodes with textChanges. Trace how the TypeScript AST and transformer APIs handle node children and text changes. Done means providing a supported way to clone an AST node together with all its children without triggering the reported assertion failure.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
compilers
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.