microsoft / microsoft/TypeScript
Union of functions with typed `this`, fails with no parameters
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 111k
- Forks
- 14.3k
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 132
Description
TypeScript Version: 4.0.2
Code
interface Context {
hello: boolean
}
type OptionsTest =
| ((this: Context) => void)
| ((this: Context) => PromiseLike<any>)
| ((this: Context, done: boolean) => void)
function container (test: OptionsTest) {
}
// This does not work!
container(function () {
console.log(this.hello);
})
// This works!
container(function (done) {
console.log(this.hello);
})
// This works!
type Single = (this: Context) => void;
function SingleContainer (test: Single) {}
SingleContainer(function () {
console.log(this.hello)
})
Expected behavior:
Correctly provide this type to (typed union) functions without arguments.
Actual behavior:
No this type is being provided for functions without arguments.
Search Terms
- contextually typed
- this parameter
- union of functions
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the linked Playground reproduction and compare contextual typing for the union in OptionsTest with the single-function Single type. Trace the compiler's handling of contextual typing, typed this parameters, and unions of functions. Done means the no-parameter callback receives Context.this while the existing parameterized and single-function cases continue to work, with regression coverage added where appropriate.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100