microsoft / microsoft/TypeScript

Enums should have a null prototype

Open
#40,740 4 comments 4 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Awaiting More Feedback Suggestion
Dominant language
Go
Stars
111k
Forks
14.3k
Avg merge
2d 4h
Merged PRs (30d)
132

Description

TypeScript Version: 4.0.2

Search Terms:

  • enum
  • string
  • prototype

Code

    const userInput = 'hasOwnProperty' as string

    enum Action {
        create,
        update
    }

    if (userInput in Action) {
      const a: Action = Action[foo as keyof typeof Action]

      console.log(typeof a) // => function
    }

Expected behavior:
Transpiled enums should have a null prototype.

Actual behavior:
Transpiled enums inherit from Object.prototype

Playground Link:
https://www.typescriptlang.org/play?ssl=11&ssc=24&pln=9&pc=29#code/MYewdgzgLgBAZiEMC8MDkALAhhA8gdzAAUAnEABwFMSoBPNAWAChnKwBXAWxgEFgoAluBgBvZjBjASlLFEoAacTHbkAJrMrMAvs2YC4MABS4ARgCtK-AHTkyUEHSpXseQqQrU6V4FgA2vwz5BcHl4RABKcNElUEhYLAAuXn4hMBRk4LAAbQQkHBgAa0paEANHSlKM1IBdXSYJWIgQX0orXxAAc0Nyyqxw7SA

Related Issues:

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked TypeScript Playground and reproduce the enum lookup using the shown code. Trace the compiler's enum emission path and assess the impact of changing the emitted object's prototype. Done means transpiled enums have a null prototype without breaking existing enum behavior, with regression coverage for the reported case.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, typescript
Domain
compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.