microsoft / microsoft/TypeScript
Strange intersection/variance behavior
Open
@weswigham is already working on this.
Since Aug 25, 2020.
Needs Investigation
- Dominant language
- Go
- Stars
- 111k
- Forks
- 14.3k
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 132
Description
TypeScript Version: Nightly (d6dda230bce0828144e5f17539d6e3f9bf4c4f3b)
Search Terms: variance, intersection
Code
interface BaseEvent {
type: string;
}
interface DerivedEvent extends BaseEvent {
type: "mytype";
payload: number;
};
type TransitionConfig<TEvent extends BaseEvent> = (event: TEvent) => void;
type TransitionsConfigMap<TEvent extends BaseEvent> =
& { splendiferous?: never } // Un/comment this line
& { [K in TEvent['type']]?: TransitionConfig<TEvent>; };
type TransitionsConfigArray<TEvent extends BaseEvent> = {
[K in TEvent['type']]: TransitionConfig<TEvent extends { type: K; } ? TEvent : never>;
}[TEvent['type']];
type AssignAction<TEvent extends BaseEvent> = (meta: TransitionsConfigMap<TEvent> | TransitionsConfigArray<TEvent>) => void;
declare const d1: AssignAction<DerivedEvent>;
declare const b1: AssignAction<BaseEvent>;
const d2: typeof d1 = b1; // Sometimes an error
const b2: typeof b1 = d1; // Sometimes an error
As-is, there are errors on both d2 and b2. If you comment out the "splendiferous" line, the error on b2 goes away. (If you disable strict function types, the error on d2 also goes away.) I find this strange, since that line does not reference TEvent.
The type names give breadcrumbs back into xstate, but I've inlined and deleted so many things that the structure is substantially different.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.