microsoft / microsoft/TypeScript

Should navto search opening projects like find all refs to give better info about world or just existing open projects

Open
#39,732 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

In Discussion Suggestion
Dominant language
Go
Stars
111k
Forks
14.3k
Avg merge
2d 4h
Merged PRs (30d)
132

Description

Yes VS Code now searches all open projects by default (on TS 3.9+). My understand is that this should only search the already opened project and not trigger a new project loads. You can disable this behavior with typescript.workspaceSymbols.scope .

I made this the default because I felt searching all projects made the most sense for the way we describe go to symbol in workspace. It is useful in the VS Code codebase for example because we usually want search results from both our extensions and our core codebase.

@amcasey VS Code cannot stream in results. We have to return them all in a single response

Originally posted by @mjbvz in https://github.com/microsoft/TypeScript/issues/38491#issuecomment-627599632

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the navto and workspace-symbol discussion, including the TypeScript 3.9+ behavior and the typescript.workspaceSymbols.scope setting. Determine the intended default between opened projects and all projects, then locate the relevant VS Code integration entry point and tests; the payload names no files or tests, so finding them is part of the work.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript, vscode
Domain
search, tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
32/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.