microsoft / microsoft/TypeScript
"Extract to function" refactor is not suggested if selection contains `if` statement (conditional return)
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 111k
- Forks
- 14.3k
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 132
Description
TypeScript Version: 3.9.2
Search Terms:
Code
const fn = ({ condition }: { condition: boolean }) => {
if (condition) {
return 1;
} else {
return 2;
}
};
Select the whole if statement, including the else, like this:

Expected behavior:
The "extract to function" refactor should be suggested. When the refactor is used, it should produce code that looks like this:
const fn = ({ condition }: { condition: boolean }) => {
return newFunction(condition);
};
function newFunction(condition: boolean) {
if (condition) {
return 1;
} else {
return 2;
}
}
Actual behavior:
The "extract to function" refactor is not suggested (testing in VS Code).
Playground Link:
Related Issues:
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the supplied TypeScript snippet in VS Code with TypeScript 3.9.2, selecting the full if statement including else. Investigate the extract-to-function refactor behavior and verify that the suggestion appears and produces the expected function extraction shown in the issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- developer-experience, tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100