microsoft / microsoft/TypeScript

unreachable code detected not work for if clause.

Open
#39,386 2 comments 4 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Awaiting More Feedback Suggestion
Dominant language
Go
Stars
111k
Forks
14.3k
Avg merge
2d 4h
Merged PRs (30d)
132

Description

TypeScript Version: 3.9.2

Search Terms: unreachable

Code

const hel2 = (x: number) => {
  switch (typeof x) {
    case 'number': return 0
  }
  x    // Unreachable code detected
}

const hel12 = (x: number) => {
  if(typeof x === 'number'){
    return 0;
  }
  x    // expect same error here!
}

Expected behavior:
in commnet

Actual behavior:
in commnet

Playground Link:
https://www.staging-typescript.org/play?#code/MYewdgzgLgBAFgUwDYCYYF4YAoAeAuGMAVwFsAjBAJwEoMA+GAbwCgYYIB3ASymDmygBPAA4IQAMxg5aLNm2ABDCAhgByYuSqqClBFCKUwMAAysYAXzM5ml5qEixESAIxpMuAhoo16TM13EsIVEJKQx0THVSb1VqWTldfUMTAG4zSzZrSyA

Related Issues:

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the TypeScript code sample and its Playground link, comparing unreachable-code diagnostics after the switch and if statements. Trace the compiler's unreachable-code analysis for these two control-flow forms and verify that equivalent cases produce the expected diagnostic before and after the change.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.