microsoft / microsoft/TypeScript

importsNotUsedAsValues = error should apply to export statements

Open
#39,339 8 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

In Discussion Suggestion
Dominant language
Go
Stars
111k
Forks
14.3k
Avg merge
2d 4h
Merged PRs (30d)
132

Description

TypeScript Version: 3.9.2

Search Terms: importsNotUsedAsValues, error, export

Code

import { Interface } from "./module";
export { Interface } from "./module";

With a "importsNotUsedAsValues" set to "error".

Expected behavior:

tsc would error on the export statement.

Actual behavior:

tsc does not error on the export statement, it only errors on the import statement. TypeScript, by default, would elide both statements in the compile and should error in the same way.

Playground Link: N/A

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the supplied two-statement example with TypeScript 3.9.2 and the importsNotUsedAsValues setting. Trace the compiler path that reports the option for the import and compare it with the export statement, then locate the relevant compiler tests. Done means the export statement reports the same error under the setting without regressing existing behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
compilers
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.