microsoft / microsoft/TypeScript
Expose isTypeReference function in public API
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 111k
- Forks
- 14.3k
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 132
Description
Search Terms
isTypeReference
Suggestion
The public compiler API exposes a getTypeArguments method on the type checker:
But provides no way to check if a type is a TypeReference. Users of the TS compiler API have to roll their own, which is error-prone. I suggest that if TypeReference is exposed in the public API, there should be a way to assert whether a type is a TypeReference.
Use Cases
See above
Examples
Currently, public uses of getTypeArguments must do something like this to assert that a type is a TypeReference:
function isTypeReference(ty: ts.Type): ty is ts.TypeReference {
return 'typeArguments' in ty;
}
const ty = getType();
if (isTypeReference(ty)) {
getChecker().getTypeArguments(ty);
}
With an exposed type guards, this becomes
const ty = getType();
if (ts.isTypeReference(ty)) {
getChecker().getTypeArguments(ty);
}
Checklist
My suggestion meets these guidelines:
- This wouldn't be a breaking change in existing TypeScript/JavaScript code
- This wouldn't change the runtime behavior of existing JavaScript code
- This could be implemented without emitting different JS based on the types of the expressions
- This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
- This feature would agree with the rest of TypeScript's Design Goals.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inspecting lib/typescript.d.ts around the exposed getTypeArguments method and the public TypeReference API. Verify that the completed API exposes ts.isTypeReference and that the example can use it to guard calls to getTypeArguments.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- compilers
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100