microsoft / microsoft/TypeScript
Expand when `isNewIdentifierLocation` is set in the syntax server
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 111k
- Forks
- 14.3k
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 132
Description
In https://github.com/microsoft/TypeScript/issues/37713, we might not have a full picture of the world, so it might overly restrictive to only suggest identifiers in the current file. We should consider being more permissive so that editors don't aggressively auto-complete on identifiers in these contexts.
Aside: if we do this, we should make sure that the work done in https://github.com/microsoft/TypeScript/issues/38836 doesn't cause conflicts.
For example, let's say you have an empty file like
thing/**/
and completions get triggered at /**/. A user should not get completions for thing at that point.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the linked issues 37713 and 38836 to understand when isNewIdentifierLocation is set and how the existing completion restrictions work. Reproduce the empty-file example with thing/**/, then define the expanded completion cases while ensuring thing itself is not suggested.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- developer-experience, devtools
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100