microsoft / microsoft/TypeScript

Add quick fix to convert type-only import into normal import

Open
#38,911 0 comments 7 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Awaiting More Feedback Suggestion
Dominant language
Go
Stars
111k
Forks
14.3k
Avg merge
2d 4h
Merged PRs (30d)
132

Description

Search Terms

convert type import

Suggestion

I'd like to have a quick fix to convert a type-only import into a normal import if the imported type is used in a value position.

Use Cases

Now that #36400 is supported, TypeScript auto-creates type-only imports for us. However, if we later decide to use the imported type in a value position, the described workflow in #36400 is still awkward. By adding a quick fix, TypeScript could make this more smooth for the developer.

Examples

import type { Foo } from "./foo";

// ... 1000 lines below

const something = Foo.staticMethod();
//                ~~~ Error: Foo cannot be used as a value

When placing the cursor on Foo here, TypeScript should offer converting the type-only import into a normal import.

Checklist

My suggestion meets these guidelines:

  • This wouldn't be a breaking change in existing TypeScript/JavaScript code
  • This wouldn't change the runtime behavior of existing JavaScript code
  • This could be implemented without emitting different JS based on the types of the expressions
  • This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
  • This feature would agree with the rest of TypeScript's Design Goals.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the example with import type { Foo } from "./foo" and a value-position use such as Foo.staticMethod(). Inspect the existing quick-fix behavior for the diagnostic and determine how the import should change. Done means the cursor on the value use offers a quick fix that converts the type-only import into a normal import.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
compilers
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.