microsoft / microsoft/TypeScript

Type Inference In Switch Statement Not Work With &&

Open
#38,580 3 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Bug Domain: check: Control Flow
Dominant language
Go
Stars
111k
Forks
14.3k
Avg merge
2d 4h
Merged PRs (30d)
132

Description

TypeScript Version: 4.0.0-dev.20200512

Search Terms: switch, inference, switch and inference

Code

interface I1 {
    type: 'I1';
    value: string;
}

interface I2 {
    type: 'I2';
    value: number;
}

type T = I1 | I2;

let t: T | undefined;

if (t && t.type == 'I1') {
    t.value; // Type string
}

switch (t?.type) {
    case 'I1':
        t.value; // Type string
        break;
}

switch (t && t.type) {
    case 'I1':
        t.value; // Uh oh, error
        t!.value; // Uh oh, string | number
        break;
}

Expected behavior:
The compile should understand that t && t.type is like as t?.type except that has also other falsy values.

Actual behavior:
The compiler does not infer from such expression.

Playground Link: https://www.typescriptlang.org/play/?ts=4.0.0-dev.20200512#code/JYOwLgpgTgZghgYwgAgJIEZkG8BQz-JgCeADhAFzIDkGVA3HgQG5wA2ArhcgM5hSgBzBgF8cOUJFiIUqAEzZG+YmUo1Z9RchYcuIdgFsARtBFjlKACrIAvGkwAfNLIY5WEMIUpXH7EABMIGFAIPxdgGGQACg8AMhjCADpzG1sadCoASgUCRO1OOmQAekLkC1IUXn4QARxRHG4Ad2AwBAALKLAAfiTyrNwchDhuFDSqck0csAS8iALi0vKePkEJgkMoCDgAa1N6ppb26OQ4xPM+zUHh6lpxnMnptnyikoBVdoB7VoAaZGgod6gqyUAEIHjo5q8Pt8llUBMhHHojNAgch1psdrUcEA

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked TypeScript Playground reproduction and compare the narrowing behavior of the three shown conditions. Trace the compiler's control-flow analysis for switch expressions using t && t.type; done means the final branch narrows t consistently with the expected behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.