microsoft / microsoft/TypeScript
Find all references on overridden subclass method includes references to the parent class
Open
Nobody has claimed this yet.
Awaiting More Feedback
Domain: LS: Symbol Navigation
Suggestion
- Dominant language
- Go
- Stars
- 111k
- Forks
- 14.3k
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 132
Description
https://github.com/microsoft/vscode/issues/93654
TypeScript Version: 3.9.0-dev.20200409
Search Terms:
- Find all references
- inheritance
Code
For the TS
class Foo {
bar() { }
}
class SubFoo extends Foo {
bar() { }
}
new SubFoo().bar();
- Run
find all referencesonbarinclass SubFoo
Expected behavior:
A reference to new SubFoo().bar(); is returned
Actual behavior:
Two references are returned, including one to the parent class's bar
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the example in VS Code using TypeScript 3.9.0-dev.20200409 and run Find All References on the overridden SubFoo.bar method. Trace the reference-finding path for inherited and overridden methods; done means the result includes new SubFoo().bar() without incorrectly including Foo.bar().
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- developer-experience
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100