microsoft / microsoft/TypeScript

new Map() infers type only from the first item in the iterable

Open
#37,527 6 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Needs Investigation
Dominant language
Go
Stars
111k
Forks
14.3k
Avg merge
2d 4h
Merged PRs (30d)
132

Description

TypeScript Version: 3.8.3

Search Terms: map infer type first item

Code

type Lookup = Map<number, boolean | string>;

const foo = new Map([
    [1, true],
    [2, 'foo']
]);

const bar: Lookup = new Map([
    [1, true],
    [2, 'foo']
]);

const baz: Lookup = new Map<number, boolean | string>([
    [1, true],
    [2, 'foo']
]);

Expected behavior: All 3 assignments work.

Actual behavior: The first 2 assignments fail because the type of the map is inferred as Map<number, () => boolean> (because of the first item). The 3rd one works but duplicates the type of the map.

Playground Link

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the TypeScript 3.8.3 behavior in the linked Playground using the three Map examples. Trace how the checker infers the type of the iterable passed to the Map constructor, then verify that all three assignments accept mixed boolean and string values without requiring a duplicated explicit type.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.