microsoft / microsoft/TypeScript
NaN incorrectly narrows to 0
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 111k
- Forks
- 14.3k
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 132
Description
TypeScript Version: 3.9.0-dev.20200222
Search Terms: NaN Truthiness Falsy
Code
function bool(): boolean { return false; }
function number(): number { return NaN; }
let a = number();
let b = bool();
const x = a && b; // type = boolean | 0
console.log(x); // prints NaN (which is neither boolean, nor 0)
Expected behavior:
Type of x should be number | boolean.
Since NaN isn't a "unit type" like 0, we can't express NaN without using number.
Actual behavior:
Type of x is 0 | boolean.
Playground Link: playground link
Related Issues:
https://github.com/microsoft/TypeScript/issues/32778 (Incorrectly marked as duplicate?)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the example in the linked TypeScript Playground and compare the inferred type of a && b with the reported runtime value. Read related issue #32778 and trace the compiler's truthiness narrowing for number values; done means NaN is not narrowed to 0, with the expected number | boolean type covered by regression testing.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100